In vanilla, the only way to interact with an item while holding shift if with an empty hand. For example, shift clicking a chest with an empty hand opens the chest but shift clicking it with a frame in hand places the frame.
I think it would be more consistent if signs behaved in a similar manner. Shift clicking a sign should open the edit screen only if the player's hand is empty. Otherwise, it should just use the item.
On vanilla minecraft, the player has to have both hand empty in order to interact with a block with holding shift. This might be a little too restrictive in our case. I think the best would be to check for empty main hand and !(offHandItem instanceof BlockItem).
In vanilla, the only way to interact with an item while holding shift if with an empty hand. For example, shift clicking a chest with an empty hand opens the chest but shift clicking it with a frame in hand places the frame.
I think it would be more consistent if signs behaved in a similar manner. Shift clicking a sign should open the edit screen only if the player's hand is empty. Otherwise, it should just use the item.
A fix would be changing the following function.
On vanilla minecraft, the player has to have both hand empty in order to interact with a block with holding shift. This might be a little too restrictive in our case. I think the best would be to check for empty main hand and
!(offHandItem instanceof BlockItem)
.