search

craftycorvid / ImprovedSigns

Improvements for your signs and frames on your Fabric/Quilt server
MIT License
11 stars 4 forks source link

Placing Amethyst Shards/Glass Panes in an item frame is impossible without turning the frame invisible #24

Closed craftycorvid closed 1 year ago

craftycorvid commented 1 year ago

I'm open to ideas for how we could allow people to still have shards/panes in item frames with the current invisible frame functionality.

craftycorvid commented 1 year ago

I think the simple solution is to not turn frames invisible if they don't have any items in them. So you could then click on a sign with an Amethyst, placing an Amethyst in it, then click on it again turning it invisible.

kingstairs commented 1 year ago

That is a reasonable workaround for the issue. Another option is to craft "invisible frames" (normal frame + amethyst/glass) before placement (if that makes sense?) - I'm assuming that the current process is changing the item frame into a new item.

craftycorvid commented 1 year ago

The problem with crafting them is that they'd be very easy to lose. Someone could craft 100 invisible frames, cover your base in them and you'd be wondering why you can't place items.

Nice thing about not being able to turn frames invisible if they're not filled is that it also gets around that issue.

kingstairs commented 1 year ago

Yes, I can see someone doing that... ;-) One solution to that mischief: Treat empty frames just like normal item frames (i.e., display them) that turn invisible when something is actually displayed. I think this is the approach some of the other frame mods use (probably for the same reason you mentioned).

craftycorvid commented 1 year ago

Fixed by dae9f7256848a71d74187283472495f6e0eae3a5