search

craftycorvid / ImprovedSigns

Improvements for your signs and frames on your Fabric/Quilt server
MIT License
11 stars 4 forks source link

Crash with Create Fabric #31

Closed supersaiyansubtlety closed 1 year ago

supersaiyansubtlety commented 1 year ago

If a sign is part of one of Create Fabric's moving block formation entities (tested gantry and minecart contraptions), and that entity becomes blocks again while a block is in the space where the sign will be placed, the game crashes.

Steps to reproduce: 1) place a rail 2) place a minecart assembler 3) place a minecart in the assembler 4) place a lever on the side of the assembler 5) place a sign on top of the assembler 6) pull the lever to assembler the contraption 7) place any block on top of the assembler (inside the entity form of the sign) 8) pull the lever again

This causes the game to crash.

latest.log: https://paste.myst.rs/nne33a9a

Corresponding issue on Create Fabric's github project: https://github.com/Fabricators-of-Create/Create/issues/954

TropheusJ commented 1 year ago

Improved Signs assumes a block entity will always be present when dropping loot. This is not true when broken directly from a contraption. This should be fixed by adding a null check here.