search

craftycorvid / ImprovedSigns

Improvements for your signs and frames on your Fabric/Quilt server
MIT License
11 stars 4 forks source link

Sign Retaining does not work with modded Signs #33

Open Dekamir opened 1 year ago

Dekamir commented 1 year ago

Signs added by mods, such as Ecologics, Farmer's Delight, Terrestria, Traverse, Cinderscapes, Improved End do not support Sign Retaining. Rest of the features seem to work. An item/block whitelist option might be needed to avoid manually supporing every single mod.

HB-Stratos commented 4 months ago

This would be quite nice to have for a modpack I am building right now. the mod https://modrinth.com/mod/signoddities can do this already (tested for farmers delight signs). It even works from vanilla to FD and back, though it can't do colors. It would be nice to have this functionality ported over.

craftycorvid commented 4 months ago

The main issue with supporting content mods is that they don't tend to keep up with Minecraft updates, but rather stick to a single version for a long time. I'm currently maintaining this mod on the latest version of Minecraft at any given time, so adding explicit compatibility for other mods gets tricky when I go to update to a new version and they have no plans to do so. I try to make the implementation of features as generic as possible so most things will work with modded signs out of the box. In the case of Sign Retaining, it currently relies on loot tables for saving the text and a crafting recipe for resetting the signs. I'm not aware of a way to implement that in a generic way, but maybe I missed something.