craftzdog / pouchdb-adapter-react-native-sqlite

PouchDB adapter using ReactNative SQLite as its backing store
https://github.com/craftzdog/pouchdb-react-native
MIT License
131 stars 25 forks source link

Update pouchdb-adapter-websql-core #11

Closed sofiageo closed 3 years ago

sofiageo commented 4 years ago

The current version of the library is giving an error when using where() with sort() in RxDB - It looks like gaodeng has forked and fixed this issue on his repository: https://github.com/gaodeng/pouchdb-adapter-websql-core

Do you think it's possible to merge the changes or create a similar implementation? Thanks

craftzdog commented 4 years ago

If he published the fork to npm, we can use it instead. The best scenario would be that his fork gets merged into the original package. So please ask him to do so, or let them know you need it on the issue.

sofiageo commented 4 years ago

It seems that there was intent to keep maintaining the websql core package but somehow it got lost in the communication here I will try to inform gaodeng in case he can ask for the repo to be added in the pouchdb community.

I would do it myself but I think I would be a terrible maintainer for a project I have no idea about :)

gaodeng commented 4 years ago

@sofiageo for pouchdb 7.1.1,you can use this in your package.json

{
    "pouchdb-adapter-react-native-sqlite": "git+https://github.com/gaodeng/pouchdb-adapter-react-native-sqlite.git#7.1.1",
}
sofiageo commented 4 years ago

Hi @gaodeng and thanks for the fixes, I'm already using your package, I'm just trying to help with organizing the next steps. Neither pubkey (RxDB maintainer) or craftzdog were aware of the issues the abandoned websql-core version was causing.

While I think it's great someone can maintain the package for the future, maybe it would also be better to put it under https://github.com/pouchdb-community - for various reasons (package easier to find, no need to change the url every time someone else will fork the project, etc)

If you don't want to put it under the community repo I understand, however, having two pouchdb-adapter-react-native-sqlite will also be confusing. What I'm trying to ask without being ungrateful is, why not collaborate with the other projects / maintainers instead of forking everything?

gaodeng commented 4 years ago

I like pouchdb a lot, but unfortunately the pouchdb main code repository seems to have been abandoned, It doesn't make sense to spend time maintaining its submodules

hosseinmd commented 4 years ago

It seems there is nothing to grow pouchdb in react-native. Realm library is very popular, but it is not useful for cross platform, in this case pouchdb is great. However, now what can we do to improve pouchdb for react-native.

craftzdog commented 3 years ago

Merged @gaodeng's patch.