search

craftzdog / solarized-osaka.nvim

🏯 A clean, dark Neovim theme written in Lua, with support for lsp, treesitter and lots of plugins.
Apache License 2.0
650 stars 29 forks source link

feature: Make it look good with Lualine #12

Closed TinusgragLin closed 7 months ago

TinusgragLin commented 7 months ago

Did you check the docs?

Is your feature request related to a problem? Please describe.

I am using this fantastic colorscheme with Lualine and I noticed that (the diff and diagnostics status part of) b section of Lualine looks quite unpleasant: 2024-01-21_21-43-24

Describe the solution you'd like

I think that we can change the normal.b.bg to make the whole thing look better. Changing foreground colors can also be done but involves more changes (e.g. setting LuaLineDiffAdd LuaLineDiffChange and LuaLineDiffDelete and changing diagnostic colors).

Describe alternatives you've considered

(None)

Additional context

No response

TinusgragLin commented 7 months ago

I see that we set normal.b.bg to colors.fg here, maybe we should change it to a darker variant?

craftzdog commented 7 months ago

yes, can you make a pr?

TinusgragLin commented 7 months ago

yes, can you make a pr?

The pr is just open!