search

craftzdog / solarized-osaka.nvim

🏯 A clean, dark Neovim theme written in Lua, with support for lsp, treesitter and lots of plugins.
Apache License 2.0
650 stars 29 forks source link

fix(lualine): lualine b section looks unpleasant #13

Closed TinusgragLin closed 7 months ago

TinusgragLin commented 7 months ago

Fixes #12. Status info in b section of Lualine was set to use light colors but the bg color was also light: 2024-01-21_21-43-24 The original plan was to darken the original normal.b.bg (was set to colors.fg) a bit, but I just found that using light colors for fg and a lightened variant of bg_statusline for bg works better: 2024-01-22_16-45-50 What do you think?

TinusgragLin commented 7 months ago

I think that all of these choices of normal.b.bg are great! bg (base04): bg

bg_highlight (base03): bg_highlight

black: black

base02: base02

orange900: orange900

yellow900: yellow900

red900: red900

magenta900: magenta900

violet900: violet900

blue900: blue900

cyan900: cyan900

Both base02 and blue900 kind of match my original change, but the orange, red, magenta and violet ones certainly add more flavors to the look. What do you think? @craftzdog

craftzdog commented 7 months ago

base03 looks nice.

TinusgragLin commented 7 months ago

base03 looks nice.

Cool, that would make section b and c seem to be connected, NeoSolarized also takes this approach! Since bg_statusline is base03, I think that I can just use bg_statusline, it makes more sense, IMO.

craftzdog commented 7 months ago

Agree!

craftzdog commented 7 months ago

Thank you~