craftzdog / solarized-osaka.nvim

🏯 A clean, dark Neovim theme written in Lua, with support for lsp, treesitter and lots of plugins.
Apache License 2.0
650 stars 29 forks source link

feat(theme): highlight updates for html,tsx,ts,js,jsx,vue,markdown #25

Closed Redoxahmii closed 6 months ago

Redoxahmii commented 6 months ago

I have added a few changes which are more similar to how tokyonight.nvim highlights and also some fixes for <> symbols in jsx and html files.

Also added a typescript treesitter tag as they appear white at the moment as they are: Screenshot from 2024-03-06 03-54-48

Screenshot from 2024-03-06 03-55-01

These are the screenshots for the .tsx, .jsx and .html files showcasing tsx and jsx being consistently same to each other and also the white <> tag fix in both jsx and html.

Screenshot from 2024-03-06 04-03-06 Screenshot from 2024-03-06 04-02-47 Screenshot from 2024-03-06 04-02-36

I tried to be as consistent as i could be for the highlights so it does not ruin the aesthetic of the colorscheme. The commit can still be edited to suit the colors you might think are not good as they are right now and adjusted according to what your preference might be. The goal was to provide the treesittter tags. Cheers!

Redoxahmii commented 6 months ago

@craftzdog This is the last gripe I had with this color scheme was when using plugins like flash.nvim the colors were so bad that you could never see what was written on the tag. I concluded that you never used this plugin because it was such a bad contrast and I later confirmed it in a video on YouTube. There was another person complaining about this too, so I changed it to use black instead of dull white.

The black text is far more readable than the white. I did not change the foreground as it would match with some colors being used in the actual syntax which I did not want just changed the text on top from white to black.

craftzdog commented 6 months ago

Thank you for the work, @Redoxahmii !

Redoxahmii commented 6 months ago

Thank you for the work, @Redoxahmii !

It was a pleasure!

bobbyrahmanda13 commented 6 months ago

Thank you for the work, @Redoxahmii !

It was a pleasure!

i love youuuuuu @Redoxahmii @craftzdog

Redoxahmii commented 6 months ago

@bobbyrahmanda13 The changes for markdown styling were removed as it was something not desired by craftzdog but if you still want to use them you can use this :

{
    "craftzdog/solarized-osaka.nvim",
    lazy = true,
    config = function()
      require("solarized-osaka").setup({
        styles = {
          sidebars = "transparent",
          floats = "transparent",
        },
        on_highlights = function(hl, c)
          local util = require("solarized-osaka.util")
          local markdown_rainbow = { c.blue, c.yellow, c.green, c.red, c.magenta, c.cyan }
          for i, color in ipairs(markdown_rainbow) do
            hl["@markup.heading." .. i .. ".markdown"] = { fg = color, bold = true }
            hl["Headline" .. i] = { bg = util.darken(color, 0.05) }
          end
        end,
      })
    end,
  }

Have fun coding!

bobbyrahmanda13 commented 6 months ago

@bobbyrahmanda13 The changes for markdown styling were removed as it was something not desired by craftzdog but if you still want to use them you can use this :

{
    "craftzdog/solarized-osaka.nvim",
    lazy = true,
    config = function()
      require("solarized-osaka").setup({
        styles = {
          sidebars = "transparent",
          floats = "transparent",
        },
        on_highlights = function(hl, c)
          local util = require("solarized-osaka.util")
          local markdown_rainbow = { c.blue, c.yellow, c.green, c.red, c.magenta, c.cyan }
          for i, color in ipairs(markdown_rainbow) do
            hl["@markup.heading." .. i .. ".markdown"] = { fg = color, bold = true }
            hl["Headline" .. i] = { bg = util.darken(color, 0.05) }
          end
        end,
      })
    end,
  }

Have fun coding!

okay, I'll use it because I'm currently learning nuxt content, thanks