craftzdog / solarized-osaka.nvim

๐Ÿฏ A clean, dark Neovim theme written in Lua, with support for lsp, treesitter and lots of plugins.
Apache License 2.0
650 stars 29 forks source link

bug: text on bg color unreadable #7

Closed AdrienLemaire closed 9 months ago

AdrienLemaire commented 9 months ago

Did you check docs and existing issues?

Neovim version (nvim -v)

v0.10.0-dev-1811+gc95b9a32f

Operating system/version

Ubuntu 22.04

Describe the bug

image

I could verify that this problem occurs with or without tmux, on both Terminal and Alacritty. I have true colors in the terminal.

I haven't modified the colorscheme config

return {
  "craftzdog/solarized-osaka.nvim",
  lazy = true,
  priority = 1000,
  opts = function()
    return {
      transparent = true,
    }
  end,
}

Steps To Reproduce

Install LazyVim with your beautiful video.

Expected Behavior

The text-on-bg should be readable

Repro

No response

craftzdog commented 9 months ago

What is the highlight group for the tokens? You can run :Inspect on one of them.

AdrienLemaire commented 9 months ago

I can't put my cursor directly on these strings, they are types generated by a typescript plugin. On the preceding character, I get:

Treesitter
  - @variable.tsx links to @variable tsx
  - @parameter.tsx links to @parameter tsx

Semantic Tokens
  - @lsp.type.parameter.typescriptreact links to @parameter priority: 125
  - @lsp.mod.declaration.typescriptreact links to @lsp priority: 126
  - @lsp.typemod.parameter.declaration.typescriptreact links to @lsp priority: 127

Extmarks
  - IlluminatedWordRead illuminate.highlight
craftzdog commented 9 months ago

I need to reproduce it. what is the typescript plugin and configuration

AdrienLemaire commented 9 months ago

Sounds difficult to reproduce... the lazy config has

{ import = "lazyvim.plugins.extras.lang.typescript" },

And I added typescript-language-server in the mason config in lsp.lua

image

AdrienLemaire commented 9 months ago

I found the rule by looking in :highlight

LspInlayHintxxx guifg=#576d74 guibg=#268bd3

image

Here are other highlight groups with critical contrast issue. I gave up looking at all the 6500 lines, and have only noticed the LspInlayHint issue so far :)

craftzdog commented 9 months ago

ah ok I wasn't on nvim 0.10 yet. will try it!

ใŠ่ช˜ใ„ใ‚ใ‚ŠใŒใจใ†ใ”ใ–ใ„ใพใ™ใ€‚ใ„ใใชใ‚Šๅ€‹ไบบ็š„ใซไผšใ†ใฎใฏใŠๆ–ญใ‚Šใ—ใฆใ„ใพใ™ใ€‚ๅคง้˜ชใฎๆ—…ใ‚’ๆฅฝใ—ใ‚“ใงใใ ใ•ใ„๏ผ

craftzdog commented 9 months ago

ok updated: https://github.com/craftzdog/solarized-osaka.nvim/commit/75e7315e5d7f76aa7e68f23cff0f5a7f1d09f2e7 https://github.com/craftzdog/solarized-osaka.nvim/commit/83b7026ac7a4e185d4ecbe99926fd94b5735e2ea thanks for reporting