craigary / nobelium

A static blog build on top of Notion and NextJS, deployed on Vercel.
https://nobelium.js.org
MIT License
3k stars 1.97k forks source link

react-cusdis, use-ackee dependency on react@17 #351

Closed nareshpingale closed 4 months ago

nareshpingale commented 5 months ago

React Cusdis doesn't seem to be maintained anymore. With its peer dependency on react 17.

Active issue on Cusdis regarding same: https://github.com/djyde/cusdis/issues/245

Added a PR adding support for reactv18 to react-cusdis npm package: https://github.com/Cusdis/sdk/pull/10

Created a temp npm package and using it meanwhile this PR is merged. https://www.npmjs.com/package/@pinging/react-cusdis

Same with use-ackee PR adding support: https://github.com/electerious/use-ackee/pull/13

npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: nobelium@1.3.0
npm ERR! Found: react@18.3.1
npm ERR! node_modules/react
npm ERR!   react@"^18.2.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^17.0.0" from react-cusdis@2.1.3
npm ERR! node_modules/react-cusdis
npm ERR!   react-cusdis@"^2.1.3" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /Users/naresh.pin/.npm/_logs/2024-06-13T06_15_42_660Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /Users/naresh.pin/.npm/_logs/2024-06-13T06_15_42_660Z-debug-0.log
stale[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

nareshpingale commented 5 months ago

update: use-ackee has merged and added support. react-cusdis still to add support.

stale[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.