craigburke / asciidoctor-asset-pipeline

AsciiDoctor Asset Pipeline module
0 stars 1 forks source link

Need to rethink diagram images #4

Open craigburke opened 8 years ago

craigburke commented 8 years ago

Right now it works if you set the imagesoutdir attribute to be within the asset root but the problem is when assetCompile runs it doesn't know about the images until the second run. These should probably be generated in the build folder and resolved from there as well.

mojavelinux commented 8 years ago

I just addressed this problem in the Jekyll plugin. There are a number of things that need to be set in order for Asciidoctor Diagram to work:

For reference, see https://github.com/asciidoctor/jekyll-asciidoc/blob/c185588a01bbeec204c3c89ed9af90115233b5ea/lib/jekyll-asciidoc.rb#L221-L233

imagesoutdir is a last resort to be used when the automatic behavior can't be relied on.

craigburke commented 8 years ago

@mojavelinux thank you, that's helpful. It does work now, so this issue is more about how I can best hook this into the asset pipeline's process.