search

craigburke / karma-gradle

Gradle Plugin for Running tests with Karma
Other
21 stars 11 forks source link

karmaRefresh cleaning entire node_modules folder #31

Open borgiani opened 7 years ago

borgiani commented 7 years ago

Hi, when running the karmaRefresh task (which depends on karmaClean), the entire node_modules folder is being cleaned. This is not very efficient in CI environments, because it causes the CI system to have to reload all node modules on every build. By looking at the code, it seems the issue could be caused by: https://github.com/craigburke/karma-gradle/blob/master/src/main/groovy/com/craigburke/gradle/KarmaPlugin.groovy#L98

I'm guessing that replacing it with file should fix it.

Thanks!

borgiani commented 7 years ago

Suggested fix: #32 Have you had the chance to review this @craigburke ?

drschulz commented 6 years ago

@craigburke Adding this fix would be greatly appreciated! I have other libraries in my project, and it takes forever to do a fresh build because of this issue.

asoftwareguy commented 6 years ago

+1

borgiani commented 6 years ago

@craigburke any chance you may have a look at this?