search

craigburke / karma-gradle

Gradle Plugin for Running tests with Karma
Other
21 stars 11 forks source link

karma config should not use root dir #8

Open musketyr opened 8 years ago

musketyr commented 8 years ago

in case of multiproject build you get the root directory of the very first parent

see https://github.com/craigburke/karma-gradle/blob/master/src/main/groovy/com/craigburke/gradle/KarmaPlugin.groovy#L106

therefor no tests are being executed

craigburke commented 8 years ago

@musketyr huh... I'll have to think about this one. I think you could probably make the case for either way depending on how your project is set up.

It's a default value and can be explicitly set to whatever you'd like, but ideally that default would work for most people.

musketyr commented 8 years ago

Well, if you run karmaRun in a project, you want to test just the given project not all siblings projects in case of multiproject builds...

Dne út 9. 2. 2016 17:58 uživatel Craig Burke notifications@github.com napsal:

@musketyr https://github.com/musketyr huh... I'll have to think about this one. I think you could probably make the case for either way depending on how your project is set up.

It's a default value and can be explicitly set to whatever you'd like, but ideally that default would work for most people.

— Reply to this email directly or view it on GitHub https://github.com/craigburke/karma-gradle/issues/8#issuecomment-181956225 .

craigburke commented 8 years ago

@musketyr that's a fair point. It probably would be a more reasonable default.

testinfected commented 8 years ago

I agree with @musketyr. Module root seems a better default.

We're having the same issue. This forces us to repeat the module prefix in all config paths.

Other than that, great plugin, thanks @craigburke