search

craigh / PostCalendar

PostCalendar is a calendar module for the Zikula Application Framework
20 stars 9 forks source link

Change of month with active category filter does not work Refs #60 #86

Closed ansch closed 11 years ago

ansch commented 11 years ago

With this change everything works fine, should be tested by others. Mayby Line 101 in admin.php needs to be changed the same way.

craigh commented 11 years ago

can you try it in admin.php and see? if so, include in this PR. thanks!

ansch commented 11 years ago

There is no difference in behaviour in the admin-view if i change it in admin.php. This Part works with both alternatives, so i really don't know what would be the best to do-

ansch commented 11 years ago

Please do not merge this until I have testet the changes. I think i will manage to test this saturday.

ansch commented 11 years ago

As far as i can tell the PR is ready for takeoff!

PhilBau commented 11 years ago

Hi, I have just applied your patch on a 8.0.1 version and I am sorry nothing has changed. I have also deleted all caches to be sure to load the correct versions.

As far as I understand, you expect to retrieve the "filtercats" value from the GET but the URL to change the month (index.php?module=postcalendar&type=user&func=display&viewtype=month&date=20131201) is not altered when I set up the filter. I am not a javascript coder so I cannot help on that one.

Or did I miss smth?

ansch commented 11 years ago

This is what i do in PostCalendar (I use the "old style" navigation): First: Opening the Month-View --> Choosing one ore more categories --> clicking on "Filter" --> PostCalendar shows the month-view with all events of my selected categories. Second: Cicking on << or >> to change the month. This second step did not work before this PullRequest. Now it works.

UPDATE: I have downloaded and installed the latest development-zip-file of PostCalendar and it works as described above.

craigh commented 11 years ago

maybe @PhilBau is using the new style - I'm not sure this is possible with the new one... not sure?

PhilBau commented 11 years ago

true, I am using the new style navigation.