oAuth-PHP-Oracle - Githubissues

craighooghiem / oauth-php

oAuth PHP

MIT License

0 stars 0 forks source link

oAuth-PHP-Oracle #58

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

This is the patch for oAuth-PHP provider with Oracle store.
It contain only updated / newly added files.

Hope it will help all the members.

For any help you can post issues here.

Original issue reported on code.google.com by vinaykant.sahu on 6 Aug 2010 at 12:34

GoogleCodeExporter commented 8 years ago

Hi Vinay! Thanks a lot!!! Questions before I commit the patch:

* why the two php classes? Apparently OAuthStoreOracle.php is useless... Right?

* do DBUSER,DBPASSWORD,DBHOST have to be defined elsewhere? I'll change them to 
come from the $options argument. 

* I don't do Oracle, but shouldn't you set the database name?

Original comment by brunobg%...@gtempaccount.com on 6 Aug 2010 at 7:15

Changed state: Accepted
Added labels: Type-Enhancement
Removed labels: Type-Defect

GoogleCodeExporter commented 8 years ago

Ooooooooops, there's an important problem. The *.prc files apparently are 
copyrighted and not opensourced. Everything you submit must be under the MIT 
license or I can't use it. 

Please verify this issue, thanks!

Original comment by brunobg%...@gtempaccount.com on 6 Aug 2010 at 7:23

Changed state: Discussion

GoogleCodeExporter commented 8 years ago

Hello,
Sorry for PCR files. Now there is no copyright with these files and these are 
100% under MIT license.
Please find updated version and remove the previous one from site and your 
record.

About the DB name : in Oracle the host and DB name mapped with each other, so 
we do not need to use select DB command like MySQl.

About OAuthStoreOracle.php: when we pass DB name in OAuthStore class it call DB 
file for that store.

Regards

Original comment by vinaykant.sahu on 7 Aug 2010 at 3:44

Attachments:

oauth-php-Oracle-Patch.rar

GoogleCodeExporter commented 8 years ago

Vinay, thanks a lot! 

I have added it to the SVN with minor changes (joined the two classes into 
one).

Original comment by brunobg%...@gtempaccount.com on 10 Aug 2010 at 6:13

Changed state: Fixed

GoogleCodeExporter commented 8 years ago

thanks, How can I get the changes from SVN for my review?

Original comment by vinaykant.sahu on 11 Aug 2010 at 9:37

GoogleCodeExporter commented 8 years ago

Sorry, I got the access, Thanks for these changes.
Now I am working on the install.php file for Oracle DB and hope update you soon.

Regards
Vinay Kant

Original comment by vinaykant.sahu on 11 Aug 2010 at 9:45