I got carried away with sorting things

[bbannon]

Move doclist.php back to the front

[bbannon]

Does it? I didn't see an 'extends Doc.php' anywhere. Maybe I missed it.

On Thu, Aug 31, 2023 at 7:01 AM Craig Knudsen @.***> wrote:

@.**** commented on this pull request.

In events_ajax.php https://github.com/craigk5n/webcalendar/pull/397#discussion_r1311594780:

@@ -31,10 +31,10 @@ require_once 'includes/validate.php';

// Load Doc classes for attachments and comments -require_once 'includes/classes/Doc.php'; require_once 'includes/classes/DocList.php';

I believe we had a bug report about this order. DocList requires Doc before it, right?

— Reply to this email directly, view it on GitHub https://github.com/craigk5n/webcalendar/pull/397#pullrequestreview-1604702960, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ7GLQNIEQ6FW2RATCGRE3XYCDLLANCNFSM6AAAAAA3T2E5CM . You are receiving this because you authored the thread.Message ID: @.***>

[craigk5n]

The problem in DocList.php is this line:

    $sql = Doc::getSQL ( $event_id, $type );

This requires Doc.php to be loaded first.

[bbannon]

Aha. I'm not really up on how classes work.

I think there are only a couple of places where doc.php should be relocated.

On Tue, Sep 5, 2023 at 9:09 AM Craig Knudsen @.***> wrote:

The problem in DocList.php is this line:

$sql = Doc::getSQL ( $event_id, $type );

This requires Doc.php to be loaded first.

— Reply to this email directly, view it on GitHub https://github.com/craigk5n/webcalendar/pull/397#issuecomment-1706805185, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ7GLXQMQKFFEMCARARAXTXY46A3ANCNFSM6AAAAAA3T2E5CM . You are receiving this because you authored the thread.Message ID: @.***>

[bbannon]

Would it be be better, or work at all, if doclist.php required doc.php?

On Tue, Sep 5, 2023 at 12:15 PM Bru Ba @.***> wrote:

Aha. I'm not really up on how classes work.

I think there are only a couple of places where doc.php should be relocated.

On Tue, Sep 5, 2023 at 9:09 AM Craig Knudsen @.***> wrote:

The problem in DocList.php is this line:

$sql = Doc::getSQL ( $event_id, $type );

This requires Doc.php to be loaded first.

— Reply to this email directly, view it on GitHub https://github.com/craigk5n/webcalendar/pull/397#issuecomment-1706805185, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ7GLXQMQKFFEMCARARAXTXY46A3ANCNFSM6AAAAAA3T2E5CM . You are receiving this because you authored the thread.Message ID: @.***>