search

craigk5n / webcalendar

WebCalendar is a PHP application used to maintain a calendar for a single user or an intranet group of users. It can also be configured as an event calendar.
http://www.k5n.us/webcalendar.php
GNU General Public License v2.0
148 stars 70 forks source link

various corrections #411

Closed bbannon closed 9 months ago

bbannon commented 9 months ago

correct spellings trim a few lines remove a few extra spaces correct bad links that I could figure out shrink a few code snippets for efficiency

bbannon commented 9 months ago

Why? They both go to the same page. And there are very few links that require the 'www.' any more.

On Wed, Sep 13, 2023 at 10:16 AM Craig Knudsen @.***> wrote:

@.**** commented on this pull request.

In tests/phpunit.xml https://github.com/craigk5n/webcalendar/pull/411#discussion_r1324763102:

@@ -1,5 +1,5 @@ <?xml version="1.0"?> -

We actually need to leave this as "www.w3.org".

— Reply to this email directly, view it on GitHub https://github.com/craigk5n/webcalendar/pull/411#pullrequestreview-1624952487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ7GLVLM7AABAU5E5UWSRLX2HL5VANCNFSM6AAAAAA4WSQKZY . You are receiving this because you authored the thread.Message ID: @.***>

craigk5n commented 9 months ago

Why? They both go to the same page. And there are very few links that require the 'www.' any more. … On Wed, Sep 13, 2023 at 10:16 AM Craig Knudsen @.> wrote: @*.*** commented on this pull request. ------------------------------ In tests/phpunit.xml <#411 (comment)>: > @@ -1,5 +1,5 @@ <?xml version="1.0"?> - We actually need to leave this as "www.w3.org". — Reply to this email directly, view it on GitHub <#411 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ7GLVLM7AABAU5E5UWSRLX2HL5VANCNFSM6AAAAAA4WSQKZY . You are receiving this because you authored the thread.Message ID: @.>

Here's how ChatGPT answered this question:

The www.w3.org is the official domain for the World Wide Web Consortium (W3C). When it comes to XML namespaces and schema locations, it's crucial to use the exact URI provided by the standard or definition, as XML parsers may rely on these exact URIs to understand or validate the document.

In the given XML header, http://www.w3.org/2001/XMLSchema-instance refers to the XML Schema instance namespace. Changing this URI (even if the changed URL still points to the same resource) can lead to compatibility and validation issues.

In other contexts, omitting "www" from a URL might be okay if the server is configured to handle requests to the domain without the "www" prefix in the same way. But in the context of XML namespaces and schema URIs, it's important to preserve them exactly as defined.

In short, for the sake of XML compatibility and validation, you should not drop the "www." from the http://www.w3.org/2001/XMLSchema-instance namespace.

bbannon commented 9 months ago

OK. That seems clear enough.

On Wed, Sep 13, 2023 at 1:53 PM Craig Knudsen @.***> wrote:

Why? They both go to the same page. And there are very few links that require the 'www.' any more. … <#m-3356809464947399556> On Wed, Sep 13, 2023 at 10:16 AM Craig Knudsen @.*> wrote: @.** commented on this pull request. ------------------------------ In tests/phpunit.xml <#411 (comment) https://github.com/craigk5n/webcalendar/pull/411#discussion_r1324763102>:

@@ -1,5 +1,5 @@ - We actually need to leave this as "www.w3.org". — Reply to this email directly, view it on GitHub <#411 (review) https://github.com/craigk5n/webcalendar/pull/411#pullrequestreview-1624952487>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ7GLVLM7AABAU5E5UWSRLX2HL5VANCNFSM6AAAAAA4WSQKZY . You are receiving this because you authored the thread.Message ID: @ .***>

Here's how ChatGPT answered this question:

The www.w3.org is the official domain for the World Wide Web Consortium (W3C). When it comes to XML namespaces and schema locations, it's crucial to use the exact URI provided by the standard or definition, as XML parsers may rely on these exact URIs to understand or validate the document.

In the given XML header, http://www.w3.org/2001/XMLSchema-instance refers to the XML Schema instance namespace. Changing this URI (even if the changed URL still points to the same resource) can lead to compatibility and validation issues.

In other contexts, omitting "www" from a URL might be okay if the server is configured to handle requests to the domain without the "www" prefix in the same way. But in the context of XML namespaces and schema URIs, it's important to preserve them exactly as defined.

In short, for the sake of XML compatibility and validation, you should not drop the "www." from the http://www.w3.org/2001/XMLSchema-instance namespace.

— Reply to this email directly, view it on GitHub https://github.com/craigk5n/webcalendar/pull/411#issuecomment-1718229707, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ7GLTHLWJPH5YCYZVCX5DX2IFKJANCNFSM6AAAAAA4WSQKZY . You are receiving this because you authored the thread.Message ID: @.***>

bbannon commented 9 months ago

Should I close the RP and redo it? Or can you merge it and then do a global search/replace?

On Wed, Sep 13, 2023 at 2:24 PM Bru Ba @.***> wrote:

OK. That seems clear enough.

On Wed, Sep 13, 2023 at 1:53 PM Craig Knudsen @.***> wrote:

Why? They both go to the same page. And there are very few links that require the 'www.' any more. … <#m_-1254672335469600144m-3356809464947399556_> On Wed, Sep 13, 2023 at 10:16 AM Craig Knudsen @.*> wrote: @.** commented on this pull request. ------------------------------ In tests/phpunit.xml <#411 (comment) https://github.com/craigk5n/webcalendar/pull/411#discussion_r1324763102>:

@@ -1,5 +1,5 @@ - We actually need to leave this as "www.w3.org". — Reply to this email directly, view it on GitHub <#411 (review) https://github.com/craigk5n/webcalendar/pull/411#pullrequestreview-1624952487>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ7GLVLM7AABAU5E5UWSRLX2HL5VANCNFSM6AAAAAA4WSQKZY . You are receiving this because you authored the thread.Message ID: @ .***>

Here's how ChatGPT answered this question:

The www.w3.org is the official domain for the World Wide Web Consortium (W3C). When it comes to XML namespaces and schema locations, it's crucial to use the exact URI provided by the standard or definition, as XML parsers may rely on these exact URIs to understand or validate the document.

In the given XML header, http://www.w3.org/2001/XMLSchema-instance refers to the XML Schema instance namespace. Changing this URI (even if the changed URL still points to the same resource) can lead to compatibility and validation issues.

In other contexts, omitting "www" from a URL might be okay if the server is configured to handle requests to the domain without the "www" prefix in the same way. But in the context of XML namespaces and schema URIs, it's important to preserve them exactly as defined.

In short, for the sake of XML compatibility and validation, you should not drop the "www." from the http://www.w3.org/2001/XMLSchema-instance namespace.

— Reply to this email directly, view it on GitHub https://github.com/craigk5n/webcalendar/pull/411#issuecomment-1718229707, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ7GLTHLWJPH5YCYZVCX5DX2IFKJANCNFSM6AAAAAA4WSQKZY . You are receiving this because you authored the thread.Message ID: @.***>

craigk5n commented 9 months ago

It's just the one file. I'll go ahead and merge and fix it on my end.