search

craigk5n / webcalendar

WebCalendar is a PHP application used to maintain a calendar for a single user or an intranet group of users. It can also be configured as an event calendar.
http://www.k5n.us/webcalendar.php
GNU General Public License v2.0
148 stars 70 forks source link

better versions of font-awesome and normalize.css #412

Closed bbannon closed 9 months ago

bbannon commented 9 months ago

I updated the rest. Not sure if that's a good thing.

craigk5n commented 9 months ago

Looks like it's failing the tests because composer.lock was not updated. Would't it be better to just let composer infer the latest compatible versions of these dependencies (i.e. "dependency management")? I don't understand the goal here...

bbannon commented 9 months ago

I ran composer require for component/font-awesome and component/normalize.css Those are better versions than the ones I did the first time. When I did that, my other composer packages got auto updated.

I haven't had any problems, but I'm not completely sure yet that newer versions of the other composer packages don't break webcalendar. So, I left composer.lock out of the commit.

The goal is to start using some free icons from font awesome that are smaller file size than what we have and look better. There are also a couple thousand free options and I think we could let our users decide which they like. Also, to use normalize.css to make all browsers, especially edge and symphony, start off with the same css 'defaults'. Without updating styles.css very often.

On Thu, Sep 14, 2023 at 7:50 AM Craig Knudsen @.***> wrote:

Looks like it's failing the tests because composer.lock was not updated. Would't it be better to just let composer infer the latest compatible versions of these dependencies (i.e. "dependency management")? I don't understand the goal here...

— Reply to this email directly, view it on GitHub https://github.com/craigk5n/webcalendar/pull/412#issuecomment-1719494223, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ7GLWE6AHKQKYTOF5SQN3X2MDSRANCNFSM6AAAAAA4XQADKU . You are receiving this because you authored the thread.Message ID: @.***>

craigk5n commented 9 months ago

You need to include composer.json and compose.lock in the same PR for it to pass the tests.

bbannon commented 9 months ago

Ah. That explains a few things. Is that only if package versions change? Maybe you could just require those 2 packages on your end and see what happens to the other packages.

On Thu, Sep 14, 2023 at 12:40 PM Craig Knudsen @.***> wrote:

You need to include composer.json and compose.lock in the same PR for it to pass the tests.

— Reply to this email directly, view it on GitHub https://github.com/craigk5n/webcalendar/pull/412#issuecomment-1719957228, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ7GLTGS64AVUGIBKMB4MTX2NFQRANCNFSM6AAAAAA4XQADKU . You are receiving this because you authored the thread.Message ID: @.***>