Closed bbannon closed 9 months ago
craigk5n
commented
9 months ago Ummmm... definitely do not want to add the vendor directory since it bloats the git repo. My vendor directory is currently 54 Mb. That would make the default webcalendar zip download of the repo HUGE. It's currently about 7 Mb. See comments in Makefile about CKEditor and how updating that one is handled.
bbannon
commented
9 months ago OK. I can see that. But, I had to delete the line for 'vendor' dir in my .gitignore to even see it for either upload or download. So, while I think it needs to be somewhere in the repo where devs can get to it, I don't think it has to be in the main distribution files. I may be wrong.
If you want to just change the composer files, I deleted the lines in the require section, ran require for each one in alphabetic order (because I wanted to see if they were inserted in the order i typed them; they are) including adding components/font-awesome and components/normalize.css.
craigk5n
commented
9 months ago Have you tested WebCalendar with bootstrap 5? Last time I looked, it wasn't a drop-in replacement for bootstrap 4.
bbannon
commented
9 months ago I have trouble with bootstrap any version. I don't know what I'm doing wrong.
One reason I'm trying font-awesome.
On Thu, Sep 21, 2023 at 9:08 PM Craig Knudsen @.***> wrote:
Have you tested WebCalendar with bootstrap 5? Last time I looked, it wasn't a drop-in replacement for bootstrap 4.
— Reply to this email directly, view it on GitHub https://github.com/craigk5n/webcalendar/pull/419#issuecomment-1730741595, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ7GLWRWOAXLMQ7QUX3YZTX3T6L7ANCNFSM6AAAAAA5AVM5K4 . You are receiving this because you authored the thread.Message ID: @.***>
craigk5n
commented
9 months ago What do you mean by "trying font-awesome"? I would think there would be a lot of CSS and other changes with a pull request to switch over the font-awesome, so I'm a bit confused about this one.
bbannon
commented
9 months ago I'm still experimenting. At the moment, I'm just hard coding the links into the vendor dir
On Fri, Sep 22, 2023 at 7:49 AM Craig Knudsen @.***> wrote:
What do you mean by "trying font-awesome"? I would think there would be a lot of CSS and other changes with a pull request to switch over the font-awesome, so I'm a bit confused about this one.
— Reply to this email directly, view it on GitHub https://github.com/craigk5n/webcalendar/pull/419#issuecomment-1731453756, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ7GLRAE5MPARHHQ22MYLDX3WJNHANCNFSM6AAAAAA5AVM5K4 . You are receiving this because you authored the thread.Message ID: @.***>
Since I'm supposed to include composer.lock, too. I also included the updated vendors, because why not?