bbannon
commented
9 months ago The original purpose was to cut the file size of the translation files. But, it seems to cause unanticipated and intermittent problems. I'm still trying to figure out why. So turning it off for now.
On Wed, Sep 27, 2023 at 1:50 PM Craig Knudsen @.***> wrote:
@.**** commented on this pull request.
In tools/update_translation.pl https://github.com/craigk5n/webcalendar/pull/422#discussion_r1339131719:
+# $trans{ 'charset' } = '=' if ( !defined( $trans{ 'charset' } ) ); +# $trans{ 'direction' } = '=' if ( !defined( $trans{ 'direction' } ) ); +# $trans{ 'mm/dd/yyyy' } = '=' +# if ( !defined( $trans{ 'mm/dd/yyyy' } ) ); +# $trans{ 'month dd' } = '=' +# if ( !defined( $trans{ 'month dd' } ) ); +# $trans{ 'month dd, yyyy' } = '=' +# if ( !defined( $trans{ 'month dd, yyyy' } ) ); +# $trans{ 'month yyyy' } = '=' +# if ( !defined( $trans{ 'month yyyy' } ) );
Why are we commenting this out? I thought it served a purpose at some point, but I don't know if it still does...
— Reply to this email directly, view it on GitHub https://github.com/craigk5n/webcalendar/pull/422#pullrequestreview-1647444917, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ7GLWXJWUGZC5W4CJZVZDX4R7Q7ANCNFSM6AAAAAA5IBOSHY . You are receiving this because you authored the thread.Message ID: @.***>
Remove a few lines that are no longer used. A little re-formatting.