Existing tests for templated messages were not matching real-world expectations of supplying either an alias or identifier but were rather sending both at once. This was hiding a type error that was discovered in #135.
Motivation and context
Fixes #135
How has this been tested?
Automated tests.
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
Go over all the following points, and put an x in all the boxes that apply.
Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
Description
Existing tests for templated messages were not matching real-world expectations of supplying either an alias or identifier but were rather sending both at once. This was hiding a type error that was discovered in #135.
Motivation and context
Fixes #135
How has this been tested?
Automated tests.
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
If you're unsure about any of these, don't hesitate to ask. We're here to help!