Fix unchecked array-key in PostmarkServiceProvider.php. - Githubissues

craigpaul / laravel-postmark

A Postmark adapter for Laravel

MIT License

204 stars 23 forks source link

Fix unchecked array-key in PostmarkServiceProvider.php. #142

Closed fvanzeijl closed 1 year ago

fvanzeijl commented 1 year ago

Fix an unchecked array-key in PostmarkServiceProvider.php.

Description

Since last 2 commits there was an unchecked array-key for message_stream_id in ServiceProvider.

Motivation and context

Closes #141

How has this been tested?

Tested with default laravel mail-config and mailable-setup from a system running good before last update.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My pull request addresses exactly one patch/feature.
[ ] I have created a branch for this patch/feature.
[x] Each individual commit in the pull request is meaningful.
[ ] I have added tests to cover my changes.
[ ] If my change requires a change to the documentation, I have updated it accordingly.

craigpaul commented 1 year ago

Thanks for the PR, but this has been resolved in 0f20810 while keeping support for the reason it was originally changed for #140