search

craigpaul / laravel-postmark

A Postmark adapter for Laravel
MIT License
204 stars 23 forks source link

message_stream_id stopped working after last commit #144

Closed nahodnyokoloiduci closed 10 months ago

nahodnyokoloiduci commented 11 months ago

Hello. In the last commit (called "Adds support for passing in Guzzle options to the Laravel HTTP client") following line has been added in src/PostmarkServiceProvider.php $config = $this->app->make('config');

unfortunately this overwrites the value of existing $config parameter, therefore few lines further down, the "_$config['message_streamid']" is always null. If you add dd($config) prior to line 22, you'll see the value of message_stream_id (if defined in mail.php). After line 23 it's undefined because the $config is overwritten.

https://github.com/craigpaul/laravel-postmark/blob/f7fa0aa150c65d513f58f14a693169d0eb2201e0/src/PostmarkServiceProvider.php

Could you please check? It's easily replicable. Thanks!

craigpaul commented 10 months ago

Hey @nahodnyokoloiduci! Thanks for catching that, totally overlooked it. This is fixed in 72d33e57786fd69ebb4dfc8cb1412fdc79785d01