craigsapp / website-polish-scores

Front-end for digital transcriptions of the Polish Music Heritage in Open Access project
https://polishscores.org
3 stars 1 forks source link

Add piano roll and prange #116

Open mkonik opened 2 years ago

mkonik commented 2 years ago

It would be usefull to add piano roll and prange models. Maybe it would make sense to differentiate types of roll for piano music and other types (esp. vocal).

For piano music use roll like at chopinscores.org image

For vocal/instrumental music it is better to use ribbon formal analysis (with additional options like in JRP) image

Clickable prange diagram should be also added image

craigsapp commented 2 years ago

Yes, of course. (Ideally issues would not be omnibuses, and rather be one specific feature at a time :-)

The problem with that piano roll system is that it has lots of bugs (such as cannot handle spine-splits). I am planning on using the Tasso and JRP piano roll viewer in any case, such as: https://www.tassomusic.org/proll/?id=Trm0003b This should generalize to any complexity of music. There will be complications dealing with instrument names (similar to histograms where problems are noted below).

For the JRP ribbon tool, this is specific to single-note parts, so there will be categories of instrumentation that are not possible to use it.

For the histograms, that version is not actually in Javascript (maybe it is Typescript), so cannot be used outside of the UI environment for which it was created. I will be using the original (which uses SCORE to generate the notation offline). This will be quite complicated to integrate a wide range of music (lots of parts for orchestra for example, scores with tacet parts that need to be suppressed), Instrument labels that are not actually instrument labels (e.g., *I"No. 5 rather than *I"piano. Adding correct instrument codes can help (such as mark music as being for piano, then "m.s." and "m.d." can be assigned to the two staves (although this will not always be true that each staff's music will be for a specific hand).

craigsapp commented 5 months ago

Pitch range plots are implemented in issue https://github.com/craigsapp/website-polish-scores/issues/236

craigsapp commented 4 months ago

prange analysis added:

https://polishscores.org/?id=pl-gd--ee-1638--008-006&con=MoBbCsMlOcTp{125}Fi{autobeam}

Screenshot 2024-02-12 at 16 37 26

proll still to be implemented 😜