search

craigsapp / website-polish-scores

Front-end for digital transcriptions of the Polish Music Heritage in Open Access project
https://polishscores.org
3 stars 1 forks source link

Major/minor mode search counts reversed #153

Closed craigsapp closed 2 years ago

craigsapp commented 2 years ago

2 A-flat major and 84 A-flat minor keys is obviously backwards since A-flat major should be common and A-flat minor uncommon:

Screen Shot 2022-05-31 at 1 04 28 AM
craigsapp commented 2 years ago

Fixed with commit https://github.com/craigsapp/website-polish-scores/commit/f57df1c5454696e6723966358b6fac9303e82b75.

Screen Shot 2022-06-02 at 12 26 47 PM

The problem was that the order of the counting was by the order of the first occurrence of the mode in the list of matched pieces.