search

craigsapp / website-polish-scores

Front-end for digital transcriptions of the Polish Music Heritage in Open Access project
https://polishscores.org
3 stars 1 forks source link

Automatic generation of extracted lyrics #214

Closed craigsapp closed 1 year ago

craigsapp commented 1 year ago

Lyrics extraction is not happening automatically. "make generate-lyrics" has to be run after the main data generation processing to add them.

Before running "make generate-lyrics":

Screenshot 2023-04-09 at 07 15 22

After running "make generate-lyrics":

Screenshot 2023-04-09 at 11 16 18

Sub-issue: It would be good to disable/hide the lyrics option in the analysis dropdown menu when there are no lyrics in the score:

Screenshot 2023-04-09 at 11 19 21

And possibly hide the "Modernize letters" option if all letters in the lyrics are already modern or modernized. And possibly check the modernize letters button when the score is in modernized view.

craigsapp commented 1 year ago

Commit https://github.com/craigsapp/nifc-digital-score-server/commit/367c40d1f78cd1ff9dd283fb6a8373d3ce7354c5 probably fixes the problem, which was that the lyrics extraction was not included in the default data generation process.

Probably fixed now, but check the next time the data is regenerated.