craigsapp / website-polish-scores

Front-end for digital transcriptions of the Polish Music Heritage in Open Access project
https://polishscores.org
3 stars 1 forks source link

Add three states to Text icon on browse toolbar #229

Closed craigsapp closed 1 year ago

craigsapp commented 1 year ago

Allow three states for the text icon on the browse bar:

craigsapp commented 1 year ago

Implemented with commit https://github.com/craigsapp/website-polish-scores/commit/ae90a240eac9ae6b196560b091a03101817e02ad

Default state:

Screenshot 2023-05-30 at 11 48 42 PM

Clicking once highlights the T and only shows/searches texted works:

Screenshot 2023-05-30 at 11 49 15 PM

(same as previously).

Clicking once more will unhighlight the T and place a ban icon on the T, indicating the only textless pieces are being shown/searched:

Screenshot 2023-05-30 at 11 50 05 PM

Clicking again will return to the original state.

Notice that texted works are 5369, textless pieces are 2079, and both are 7448 (the sum of the previous two counts).

craigsapp commented 1 year ago

There are 8 scores that have modernized scores, IIIF markup and do not have text:

Screenshot 2023-05-30 at 11 53 54 PM

These scores, at least the highlighted Benedictus, have text, so something needs to be fixed.

craigsapp commented 1 year ago

Fixed with commit https://github.com/craigsapp/website-polish-scores/commit/d60dbc15f758a567048bb74c139a6d4b661a2f4e

Now there are 59 scores that have modernized scores, IIIF markup and are textless:

Screenshot 2023-05-31 at 12 14 01 AM

The problem was a typo in the variable name input2 (originally left as input after code copy-and-paste).