craigsapp / website-polish-scores

Front-end for digital transcriptions of the Polish Music Heritage in Open Access project
https://polishscores.org
3 stars 1 forks source link

Unhide barlines when doing automatic modernizations #248

Closed craigsapp closed 5 months ago

craigsapp commented 5 months ago

When there is no modernization filters in a score, add a shed filter to unhide invisible barlines.

Example:

Here is the original (diplomatic) version of the score:

https://polishscores.org/?id=pl-gd--ee-1638--008-001

Screenshot 2024-01-24 at 01 53 23

Here is the current automatically modernized score:

Screenshot 2024-01-24 at 01 54 30

Notice that there are ties added across invisible barlines, but the barlines should also be shown automatically.

craigsapp commented 5 months ago

Implemented with commit https://github.com/craigsapp/website-polish-scores/commit/acb0932b325ec2ac55ea490b921e242d1457d4ac

Example:

Screenshot 2024-01-24 at 02 16 26

Note that the system decoration for this score:

!!!system-decoration: [(s1,s2,s3,s4,s5,s6)]

Should instead be:

!!!system-decoration: [s1,s2,s3,s4,s5,s6]

Or shorthand:

!!!system-decoration: [*]

This will not draw measure lines between staves in the score, which is more standard for vocal music with text (because the barlines interfere with the readability of the lyrics):

Screenshot 2024-01-24 at 02 28 00