craigsapp / website-polish-scores

Front-end for digital transcriptions of the Polish Music Heritage in Open Access project
https://polishscores.org
3 stars 1 forks source link

Prevent lyrics filter for links to VHV #260

Closed craigsapp closed 4 months ago

craigsapp commented 4 months ago

Example: https://polishscores.org/?id=pl-kk--kk-i-482--002-004

When the lyrics extraction analysis is active:

Screenshot 2024-02-05 at 14 06 18

Clicking on the H button in the navigator opens the score in VHV:

https://verovio.humdrum.org/?file=https%3A%2F%2Fhumdrum.nifc.pl%2Fpl-kk--kk-i-482--002-004.krn&filter=lyrics

Screenshot 2024-02-05 at 14 12 55

But there is no lyrics filter available in VHV, so a warning is given:

Screenshot 2024-02-05 at 14 13 31

Prevent the lyrics tool from being added to the VHV URL.

Or alternatively, implement a lyrics tool in humlib. (Currently the lyrics analysis is cached on the data server and the tool is written in PERL connecting several Humdrum tools together).

craigsapp commented 4 months ago

Fixed with commit https://github.com/craigsapp/website-polish-scores/commit/85242605406326a73b89d21d1eb2037a6dfc9085

craigsapp commented 4 months ago

Somehow not working again (or maybe lyrics filter added through some other path):

https://verovio.humdrum.org/?file=https%3A%2F%2Fhumdrum.nifc.pl%2Fpl-wn--mus-iii-86-055.krn&filter=lyrics

When clicking on the H button in the navigator toolbar on this page:

https://polishscores.org/?id=pl-wn--mus-iii-86-055

craigsapp commented 4 months ago

Forgot to add return:

Screenshot 2024-02-07 at 09 33 09

Fixed in commit https://github.com/craigsapp/website-polish-scores/commit/8b466f4f7b7f3e65d045c72e347b7866e0527d59