craigsapp / website-polish-scores

Front-end for digital transcriptions of the Polish Music Heritage in Open Access project
https://polishscores.org
3 stars 1 forks source link

configuration filter does not transfer to VHV link #264

Closed craigsapp closed 7 months ago

craigsapp commented 7 months ago

When a free-form filter in the notation configuration pane is active

https://polishscores.org/?id=pl-stab--5a--001-007&config=Fi{extract%20-k1}

Screenshot 2024-02-09 at 18 42 26

The VHV link (when clicking on H button in the navigation toolbar):

Screenshot 2024-02-09 at 18 43 30

Does not include the filter:

https://verovio.humdrum.org/?file=https%3A%2F%2Fhumdrum.nifc.pl%2Fpl-stab--5a--001-007.krn

Screenshot 2024-02-09 at 18 44 19

Transfer free-form filter to the filter parameter in the URL, which should then be placed in the filter input in the toolbar of VHV (top right in above image).

craigsapp commented 7 months ago

Implemented in commit https://github.com/craigsapp/website-polish-scores/commit/66bc0d1509da6a1be3b7058b7eccdfe041147778

Example:

http://127.0.0.1:3434/?id=pl-stab--5a--001-007&config=Fi{extract%20-k1}

Screenshot 2024-02-09 at 19 10 40

Now generates the URL https://verovio.humdrum.org/?file=https:%2F%2Fhumdrum.nifc.pl%2Fpl-stab--5a--001-007.krn&filter=extract%20-k1

Screenshot 2024-02-09 at 19 09 32

Currently only the analysis filter (which has priority) or the free-form configuration filter will be used. In the future allow mixing these two filters, as well as other configuration settings.