craigsapp / website-polish-scores

Front-end for digital transcriptions of the Polish Music Heritage in Open Access project
https://polishscores.org
3 stars 1 forks source link

PB/SB when using --breaks original #278

Closed craigsapp closed 7 months ago

craigsapp commented 7 months ago

When verovio uses the option --breaks original, page breaks will force pagination of the rendered score, and the full score cannot be seen on a long single page as an SVG. More proper on the single-page display on polishscores.org (but preserving original system breaks), the option --breaks line should be used. This will convert original page breaks into system breaks.

craigsapp commented 7 months ago

Implemented with commit https://github.com/craigsapp/website-polish-scores/commit/7c853621a9d519779810fa56e1c736ea11e094f1

Now the entire score is shown when the "Original system breaks" option is selected in the configuration panel:

https://polishscores.org/?id=18xx:3901&con=Ob

Screenshot 2024-02-11 at 15 35 58

(before it was stopping at measure 11)

Some line breaks are missing in this score:

Extra line break added at measure 15:

Screenshot 2024-02-11 at 15 40 43

Which was probably supposed to be added at the start of measure 18:

Screenshot 2024-02-11 at 15 41 37

The last page does not have line breaks:

Screenshot 2024-02-11 at 15 42 32

Probably related to issue #277, where the last page of the source is missing (and the encode added from another source but did not encode the system breaks.

VHV link to score: https://verovio.humdrum.org/?file=https:%2F%2Fhumdrum.nifc.pl%2F18xx:3901.krn

jacekiwaszko1 commented 7 months ago

Some line breaks are missing in this score:

It looks like the XML editor used a different source to fill in the missing parts, and the Humdrum editor skipped it. I fixed the encoding and pushed the changes to our local repository.

craigsapp commented 7 months ago

OK, I will update publications of the scores (sooner or later).

craigsapp commented 7 months ago

Note a correction to LO:LB in issue (towards the end of the second post): https://github.com/craigsapp/website-polish-scores/issues/282