search

craigthomas / Chip8Java

A Super Chip 8 emulator written in Java
MIT License
27 stars 2 forks source link

Fix trace and step mode on startup. #12

Closed craigthomas closed 5 years ago

craigthomas commented 5 years ago

This PR fixes step and trace modes on emulator startup. Previously, if the emulator was started in step or trace modes, it would not execute any code at all. This is because internal state variables were not marked volatile and were therefore not accessible outside of the main emulator thread. Also, checkbox controls were synced to the trace and step flags issued on startup, where previously they were not.

Version number bumped for fix.

codecov[bot] commented 5 years ago

Codecov Report

Merging #12 into master will decrease coverage by 10.85%. The diff coverage is 8.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #12       +/-   ##
=============================================
- Coverage     84.44%   73.58%   -10.86%     
+ Complexity      210      200       -10     
=============================================
  Files            15       15               
  Lines           842      848        +6     
  Branches         55       55               
=============================================
- Hits            711      624       -87     
- Misses          121      217       +96     
+ Partials         10        7        -3
Impacted Files Coverage Δ Complexity Δ
...m/chip8java/emulator/components/EmulatorState.java 0% <0%> (-100%) 0 <0> (-1)
...va/com/chip8java/emulator/components/Emulator.java 0.56% <0%> (-49.44%) 1 <0> (-9)
.../emulator/listeners/OpenROMFileActionListener.java 81.48% <50%> (-2.52%) 4 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 156bd68...8c91c4d. Read the comment docs.