search

craigwatson / bitcoind-status

PHP application to display status and information from the Bitcoin node daemon.
https://odin.vikingserv.net
Apache License 2.0
82 stars 77 forks source link

Move donate message to donation block #38

Closed jamesmacwhite closed 6 years ago

jamesmacwhite commented 6 years ago

I think it makes more sense semantically for the donation message to be within the block with the QR code. That way if the intro_block contains a string this provides a more dedicated space and clearance for that message to be displayed across the overall width of the web app.

jamesmacwhite commented 6 years ago

So by default, its enabled, but you have the donation address as not_set, so out of the box without changing anything you'll have the donation message appear with not_set. Maybe the better approach would be for the template to check for != not_set instead to keep the default setting true and prevent it being displayed. I can adjust this logic if you think that's reasonable?