search

craigwatson / puppet-vmwaretools

Puppet module for non-OSP VMware Tools Installation
http://forge.puppetlabs.com/CraigWatson1987/vmwaretools
Apache License 2.0
27 stars 40 forks source link

module does not recover form md5sum error #30

Closed hbog closed 10 years ago

hbog commented 10 years ago

Hi Craig Thank you for sharing this nice module. I ran into following issue: When there is an md5sum error, for example due to a failure in downloading the archive, the module does not retry the download during subsequent puppet runs but keeps on failing trying to run the non-existing '/usr/bin/vmware-toolbox-cmd'. I have resolved this by adding ' refreshonly => false' to the 'download_vmwaretools' resource. This triggers a new download (and subsequent execution) of the dowload script when the vmware tools install didn't succeed during a previous run. You might want to merge this in your code, or solve this issue in another way. Best regards Herwig Bogaert

craigwatson commented 10 years ago

Hi,

Thanks for reporting the issue - apologies for the delay in responding!

I've fixed the issue by removing the archive with the download script if the MD5 doesn't match - it doesn't make sense to keep a bad archive anyway :)

Thanks!

hbog commented 10 years ago

Hi Craig

Thanks for the fix.

Best regards

Herwig

On Wed, Mar 5, 2014 at 1:11 PM, Craig Watson notifications@github.comwrote:

Hi,

Thanks for reporting the issue - apologies for the delay in responding!

I've fixed the issue by removing the archive with the download script if the MD5 doesn't match - it doesn't make sense to keep a bad archive anyway :)

Thanks!

Reply to this email directly or view it on GitHubhttps://github.com/craigwatson/puppet-vmwaretools/issues/30#issuecomment-36736164 .

Herwig Bogaert Senior Systems Engineer

VIAA - iMinds vzw* | Gaston Crommenlaan 8 box 102 | 9050 Ghent | Belgium | www.viaa.be http://www.iminds.be*

T: +32 9 275 31 72 | F: +32 9 331 48 05 | M: +32 478 42 22 55