search

craigwatson / puppet-vmwaretools

Puppet module for non-OSP VMware Tools Installation
http://forge.puppetlabs.com/CraigWatson1987/vmwaretools
Apache License 2.0
27 stars 40 forks source link

Installation fails with "vmware-config-tools.pl" not found #40

Closed jskarpe closed 10 years ago

jskarpe commented 10 years ago

notice: /Stage[main]/Vmwaretools::Install::Package/Package[vmware-tools-services]/ensure: created notice: /Stage[main]/Vmwaretools::Install::Package/Package[open-vm-dkms]/ensure: created notice: /Stage[main]/Vmwaretools::Install::Package/Package[open-vm-tools]/ensure: created err: /Stage[main]/Vmwaretools::Config_tools/Exec[vmware_config_tools]/returns: change from notrun to 0 failed: Could not find command '/usr/bin/vmware-config-tools.pl'

CentOS 6.5, 2.6.32-431.17.1.el6.x86_64

craigwatson commented 10 years ago

Thanks for the report - this looks like the tool aren't being downloaded, so the $deploy_tools variable isn't being set to true.

Can you post the output of facter -p and confirm if VMware Tools are already installed, as well as the exact parameters you're passing to the module?

jskarpe commented 10 years ago

With regards to params, I'm passing version and md5 (tar.gz downloaded using Puppet).

I found that some vmware-tools packages was deployed already. Manually removing these solved my issue.

However, puppet still does this on every run:

notice: /Stage[main]/Vmwaretools::Config_tools/Exec[vmware_config_tools]/returns: executed successfully notice: /Stage[main]/Vmwaretools::Install::Package/Package[vmware-tools-services]/ensure: created notice: /Stage[main]/Vmwaretools::Install::Package/Package[open-vm-dkms]/ensure: created notice: /Stage[main]/Vmwaretools::Install::Package/Package[open-vm-tools]/ensure: created

My Ubuntu machines does not show this behavior.

jskarpe commented 10 years ago

The problem with the never ending installation on CentOS is triggered by wrong value for: config_creates_real

For CentOS, it should stay at the default value.

craigwatson commented 10 years ago

Awesome, thanks!

FWIW, this will be fixed in version 0.4.1 of the module (currently in testing - you can try it out by cloning direct from GitHub rather than downloading from the Forge) as I'm moving to an lsmod unless-check on the vmware-config-tools exec :)

I'll close this issue for now, but please do feel free to re-open it if the issue still happens after 0.4.1 :)