Module errors on Windows

craigwatson / puppet-vmwaretools

Puppet module for non-OSP VMware Tools Installation

http://forge.puppetlabs.com/CraigWatson1987/vmwaretools

Apache License 2.0

27 stars 40 forks source link

Module errors on Windows #47

Closed ITestInProd closed 10 years ago

ITestInProd commented 10 years ago

The module causes execution errors when included on Windows agents. This is problematic in our environment as our other modules are written to be OS agnostic when added to our generic Host groups in Foreman.

craigwatson commented 10 years ago

Thanks for the feedback, can you include output of facter -p when run on a Windows machine?

ITestInProd commented 10 years ago

Pull request: https://github.com/craigwatson/puppet-vmwaretools/pull/48

craigwatson commented 10 years ago

Thanks - I've just committed e9cf131 which should fix the issue on Windows platforms.

Can you re-test against the current HEAD?

ITestInProd commented 10 years ago

No issues against current HEAD.

craigwatson commented 10 years ago

Thanks for the feedback, I'll close the issue. The changes will be released to the forge when I have time.