search

craigwatson / puppet-vmwaretools

Puppet module for non-OSP VMware Tools Installation
http://forge.puppetlabs.com/CraigWatson1987/vmwaretools
Apache License 2.0
27 stars 40 forks source link

Fact being returned as string failing silently #54

Closed sockleblu closed 9 years ago

sockleblu commented 9 years ago

Hi Craig. I've been testing out your module and while I could get a manifest to work locally I couldn't get the module to work if it was trying to load the catalog from a remote master server. After playing around with the code I found it was failing on line 118 in the init.pp file. I wasn't getting a warning about the fact returning the boolean as a string but instead it would fail with nothing thrown. I changed the line to be from:

if $::is_virtual == true and $::virtual == 'vmware' and $::kernel == 'Linux' {

to:

if $::is_virtual == true or $::is_virtual == 'true' and $::virtual == 'vmware' and $::kernel == 'Linux' {

adding an OR condition for a boolean that's a string. It seems to be working properly now on all of my machines and I just wanted to run this by you. I'm not sure why it was failing with no warning but my Puppet version is: 3.5.1 and Facter is: 2.2.0

Hopefully this helps!

craigwatson commented 9 years ago

Hey,

Thanks for the comments - the bug you mention is either a bug or a regression (depending on the module version you're running!) and has been fixed in the most recent version (1.1.0).

Can you confirm the issue exists with 1.1.0?

sockleblu commented 9 years ago

Hey Craig, thanks for the speedy reply. I didn't notice there was a newer version released but I've tested it out and it looks to be working fine so far. The code has a more elegant solution in place then mine as well. Thanks for taking care of it

-Kyle

On Wed, Oct 8, 2014 at 1:45 PM, Craig Watson notifications@github.com wrote:

Hey,

Thanks for the comments - the bug you mention is either a bug or a regression (depending on the module version you're running!) and has been fixed in the most recent version (1.1.0).

Can you confirm the issue exists with 1.1.0?

— Reply to this email directly or view it on GitHub https://github.com/craigwatson/puppet-vmwaretools/issues/54#issuecomment-58424587 .

"The quieter you become, the more you are able to hear"