Closed esalberg closed 9 years ago
craigwatson
commented
9 years ago Hey - apologies for the delay!
Good question! The "prevent_upgrade" option seems to be the cleanest solution as we need the version to be reported for the "prevent_downgrade" to work properly.
I unforutnately won't have time to add the functionality to the module before mid-December due to work commitments, but I'll absolutely accept a PR :)
esalberg
commented
9 years ago Great! I will put together a pull request now that I know the way to go. :)
esalberg
commented
9 years ago My puppet-lint check failed against this line in init.pp: if (($archive_url == 'puppet') or ('puppet://' in $archive_url)) {
It's objecting to the "in $archive_url" part.
I'm going to replace it with the following, unless there's a case I'm not thinking of where the 'puppet://' would not be the beginning of the line (or this sort of regex is only supported in later versions of Puppet)?
($archive_url =~ /^puppet:\/\//)
craigwatson
commented
9 years ago Fixed in #58
I wanted to check and see if this made any sense before submitting a pull request. We currently want to use this module to install and configure VMware tools but not to upgrade (in the short term, until we know how many servers would be affected).
I can see two possible ways to make this work: 1) Add an option for "installed" (e.g. no specification of version) 2) Add an option for "prevent_upgrade", similar to prevent_downgrade
This is basically a short-term strategy so that we can get the custom facts onto the systems and make it easy to determine if we have tools out of synch. Once we're past the initial phase, we'll likely allow upgrades.
Thank you!