craigwatson / puppet-vmwaretools

Puppet module for non-OSP VMware Tools Installation
http://forge.puppetlabs.com/CraigWatson1987/vmwaretools
Apache License 2.0
27 stars 40 forks source link

Build tools and headers conflict with other puppet modules. #59

Closed Aethylred closed 9 years ago

Aethylred commented 9 years ago

I use puppetlabs-gcc to install and maintain build tools and headers. https://forge.puppetlabs.com/puppetlabs/gcc

This isn't getting along with puppet-vmwaretools as they're not yeilding to each other over installing common packages.

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Duplicate declaration: Package[build-essential] is already declared in file /etc/puppet/environments/production/library/vmwaretools/manifests/install/package.pp:51; cannot redeclare at /etc/puppet/environments/production/library/gcc/manifests/init.pp:19 on node git.test.nesi.org.nz
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

Making installing the build tools optional would resolve this (making a PR).

craigwatson commented 9 years ago

Thanks for the PR, can you test with my slightly revised logic code?

Aethylred commented 9 years ago

I'm using it in my current test environment. So it's good.

craigwatson commented 9 years ago

Perfect, closing this issue then :)