search

craigwatson / puppet-vmwaretools

Puppet module for non-OSP VMware Tools Installation
http://forge.puppetlabs.com/CraigWatson1987/vmwaretools
Apache License 2.0
27 stars 40 forks source link

Added packages to $purge_package_list #73

Closed oneingan closed 9 years ago

oneingan commented 9 years ago

Based in vmware-install.pl package list Solves issue #72

craigwatson commented 9 years ago

Thanks for the PR, much appreciated!

Seems very pedantic, but can you make sure that the indentation is in two-space increments? Should just need one more from my reckoning:

$purge_package_list = [ 'open-vm-tools', 'open-vm-dkms', 'vmware-tools-services',
                        'vmware-tools-foundation', 'open-vm-tools-desktop',
                         ... ]
oneingan commented 9 years ago

ok, i've changed it

On Fri, Aug 28, 2015 at 1:27 PM, Craig Watson notifications@github.com wrote:

Thanks for the PR, much appreciated!

Seems very pedantic, but can you make sure that the indentation is in two-space increments? Should just need one more from my reckoning:

$purge_package_list = [ 'open-vm-tools', 'open-vm-dkms', 'vmware-tools-services', 'vmware-tools-foundation', 'open-vm-tools-desktop', ... ]

— Reply to this email directly or view it on GitHub https://github.com/craigwatson/puppet-vmwaretools/pull/73#issuecomment-135744683 .