search

craigwatson / puppet-vmwaretools

Puppet module for non-OSP VMware Tools Installation
http://forge.puppetlabs.com/CraigWatson1987/vmwaretools
Apache License 2.0
27 stars 40 forks source link

Added option to use proxy for curl command #78

Closed dutsmiller closed 8 years ago

craigwatson commented 8 years ago

Thanks for the PR - nice addition!

Can you modify the ERB code to use scope.lookupvar as per the other variables in the file, and also add documentation for the option you're adding at the top of init.pp?

dutsmiller commented 8 years ago

Hope that's what you were looking for, I'm a novice at public PRs :)

craigwatson commented 8 years ago

No problem - don't worry about the Travis CI failures, I'm aware of an issue with my module and the newer Travis infrastructure.

All looks good apart from the comment above :)

dutsmiller commented 8 years ago

works for me, I like simple