search

craigwblake / redline

Pure Java Rpm Library
http://redline-rpm.org
MIT License
128 stars 97 forks source link

Revert back to 32 bit inode values #104

Closed rmquapp closed 8 years ago

rmquapp commented 8 years ago

I was hitting issue #97 and switching the inode values from 64 bit back to 32 has solved it for me.

The rpms created with this change install fine on both CentOS 5 with RPM 4.4 and CentOS 7 with RPM 4.11.

rschlussel-zz commented 8 years ago

@craigwblake thoughts on this pull request? Being able to create rpms that can run both on rpm 4.4 and 4.11 is a major requirement for us.

We've been using redline for Presto and had been creating 2 different artifacts to support different versions of rpm (redline <1.2.2 doesn't work on rpm >= 4.11 and redline==1.2.2 doesn't work on rpm < 4.6). But we've ended up with way too many support issues from people using the wrong rpm.

sc1478 commented 8 years ago

I agree with rschlussel, although perhaps it should be an option to select the inode value size and/or support for different versions of rpm. But I definitely have the same requirement as he does. And any option should have a hook accessible to downstream products like os-nebula. https://github.com/craigwblake/redline/issues/107 is probably a duplicate of this issue

sc1478 commented 8 years ago

OK, I have adopted as a temporary workaround, this pull request which works for my requirements which include support for RPM versions from 4.3.3 to 4.8.0.

I realize that this won't work for everyone, but I'm very grateful to @rmquapp for finding the cause and opening this PR. I don't know what can be done for the whole user community. Perhaps an optional switch based on targeted RPM versions would be the only way.