craigwblake / redline

Pure Java Rpm Library
http://redline-rpm.org
MIT License
128 stars 97 forks source link

Initial experiments for supporting verify flags. #73

Closed oesolutions closed 9 years ago

oesolutions commented 9 years ago

Hi Craig,

I'm looking into adding some support for the verify flags. Does it seem like I'm on the right track or am I way off base?

Thanks, Chris

craigwblake commented 9 years ago

Hi Chris, looks fine to me. If you want to add something like Directive it should really be an enum - Directive was originally added back before Java 5 was out, hence the old style. Maybe one day we'll get Directive updated to be an enum as well. ;)

I'm okay either pulling this in the interim or waiting for an update to add the enum, let me know which you prefer.

oesolutions commented 9 years ago

I've done zero testing so it's probably a good idea to wait. It was getting late when I did this and I just wanted to get your initial feedback before I put more effort into it. Thanks for taking a look.

craigwblake commented 9 years ago

Merging this as is since it's a simple addition and will allow some wider testing.