craisinlord / Integrated-Stronghold

GNU Lesser General Public License v3.0
2 stars 1 forks source link

Normal stronghold loot not available? #5

Open SPYROHAWK opened 1 month ago

SPYROHAWK commented 1 month ago

I have flown around a few strongholds in spectator mode as well as looking through the GitHub code to the best of my ability, and it seems that every single loot chest in the structure is a uniquely defined Integrated Stronghold loot table. Which is cool, everything is custom.

However, this means that if a mod makes an item only available in stronghold loot chests, it’s not available anymore, since none of the chests contain normal stronghold loot.

For example, the Miskatonic Mysteries mod (fabric 1.19.2) adds an item called the Incantation of the Gate-and-Key. It can be found super rarely in normal dungeons and in igloos (which are super hard to find), and it can be found more commonly in Stronghold Library chests. This is the intended method of getting the item, from the stronghold. But since the Integrated Stronghold libraries only seem to be using their own custom loot and not the vanilla Stronghold Library loot table that the item is being injected into, that now means the item is significantly harder to obtain.

That’s the only one I know off the top of my head, but I know I’ve seen other mods that similarly use the stronghold library or stronghold corridor loot tables to house certain items for their progression.

The easy solution to this would to be have a few chests with the vanilla loot tables in the structure (you would even put them in the secret lab or something) so those items do not become unobtainable.

I apologize if this is already the case and I’m just being an idiot, but I checked the code and I don’t think any of the vanilla loot tables are used anywhere.

AverageUser67 commented 3 weeks ago

Isn't there a config datapack for this exact reason? Just add the gate-and-key/chalks/whatever to the loot-table

SPYROHAWK commented 3 weeks ago

Is there? I couldn't find any config for it just in the normal configs folder, but I'm also very unfamiliar with datapack stuff.

AverageUser67 commented 2 weeks ago

https://www.curseforge.com/minecraft/texture-packs/integrated-stronghold-config/download/4558191

There should be loot tables somewhere in there, just add the items you want