search

crankyoldgit / IRremoteESP8266

Infrared remote library for ESP8266/ESP32: send and receive infrared signals with multiple protocols. Based on: https://github.com/shirriff/Arduino-IRremote/
GNU Lesser General Public License v2.1
2.84k stars 810 forks source link

The implementation and declaration of some functions differs from the function call #2101

Closed MarkKoshelev closed 3 weeks ago

MarkKoshelev commented 4 weeks ago

I encountered this when my AC Haier was not working correctly. src/IRac.cpp 1460: void IRac::haier176(IRHaierAC176 *ac, const haier_ac176_remote_model_t model, const bool on, const stdAc::opmode_t mode, const bool celsius, const float degrees, const stdAc::fanspeed_t fan, const stdAc::swingv_t swingv, const stdAc::swingh_t swingh, const bool turbo, const bool quiet, const bool filter, const int16_t sleep)

3289: haier176(&ac, (haier_ac176_remote_model_t)send.model, send.power, send.mode, send.celsius, send.degrees, send.fanspeed, send.swingv, send.swingh, send.turbo, send.filter, send.sleep);

The call of function haier176 dont have "const bool quiet" argument

crankyoldgit commented 3 weeks ago

@MarkKoshelev I think I've fixed it. Can you please confirm it now operates as expected in the master branch?

MarkKoshelev commented 8 hours ago

@MarkKoshelev I think I've fixed it. Can you please confirm it now operates as expected in the master branch?

You have fixed ony one function (haier176). But the same bug is in a nubber of functions. I see them in haierYrwo2 also. Please check all functions declaration and implementation. All haierXXX function have this bug.

NiKiZe commented 30 minutes ago

@MarkKoshelev I think I've fixed it. Can you please confirm it now operates as expected in the master branch?

You have fixed ony one function (haier176). But the same bug is in a nubber of functions. I see them in haierYrwo2 also. Please check all functions declaration and implementation. All haierXXX function have this bug.

Feel free to create one or more PRs 😉