search

crankyoldgit / IRremoteESP8266

Infrared remote library for ESP8266/ESP32: send and receive infrared signals with multiple protocols. Based on: https://github.com/shirriff/Arduino-IRremote/
GNU Lesser General Public License v2.1
2.84k stars 810 forks source link

Supported FUNIKI remote AC #2113

Open QuangThai2297 opened 4 days ago

QuangThai2297 commented 4 days ago

This merge request adds basic support for the FUNIKI remote. This includes support for almostly decode data from remote as power on/off, temperature, mode, fan, clock, timer on/off, swingV, sleep,.. and support sending almostly setting except timer on/off. For information about this remote, you can refer this issue at https://github.com/crankyoldgit/IRremoteESP8266/issues/2112 It is old remote model. Data has no checksum byte, and is very easy to decode. Thanks!

QuangThai2297 commented 3 days ago

Can anyone help me resolve this failing after check PRs below? "Library Linter / supported-devices-check (pull_request) Failing after 6s" I am new here and this is the first time I contribute this project! Thanks!

crankyoldgit commented 3 days ago

Can anyone help me resolve this failing after check PRs below? "Library Linter / supported-devices-check (pull_request) Failing after 6s" I am new here and this is the first time I contribute this project! Thanks!

I've given you a code review. See the review comment for the ir_Funiki.h file.

Basically you are missing some info in the header file that we scan for to help automatically build some of the documentation for the project. Namely https://github.com/crankyoldgit/IRremoteESP8266/blob/master/SupportedProtocols.md

QuangThai2297 commented 2 days ago

Thanks for this. Looks mostly good. Can you supply some raw data and what the "raw" A/C message is supposed to be/do etc. i.e. the settings state.

Now I have just updated new commit. I removed un-needed something as you recommended. And you can also see "All checks have passed". For raw message from remote capture, you can refer attached file below: FUNIKI_remote_AC_Raw_code_decode.txt