crankyoldgit / IRremoteESP8266

Infrared remote library for ESP8266/ESP32: send and receive infrared signals with multiple protocols. Based on: https://github.com/shirriff/Arduino-IRremote/

GNU Lesser General Public License v2.1

2.95k stars 831 forks source link

Esp32 Core version 3 #2144

Open BorisKofman opened 3 weeks ago

BorisKofman commented 3 weeks ago

Fixes #2039

NiKiZe commented 3 weeks ago

Duplicate of #2040 / #2039 ?

But please provide an explanation if this has any improvements over the other.

BorisKofman commented 3 weeks ago

Feature:

Make IRremoteESP8266 compatible with IDF 5.x ESP32 Version 3

BorisKofman commented 3 weeks ago

@NiKiZe code is running on ESP32 S3 With ESP32 Version 3.0.4 without any errors

I will try to test with ESP32-DEV & ESP32-C6 this weak

NiKiZe commented 3 weeks ago

As I understand it, so is #2040, we are grateful for your PR. Just want to limit duplication if there already is a fully working implementation.

BorisKofman commented 3 weeks ago

Thanks @NiKiZe, With #2040 I get error: timer is not enabled yet I will try to test my Code with IDF 5.x and much Boards that I can Currently tested "IDF 5.X" with S3. Tomorrow will try with C6 and esp32-dev. Then I will revert to ESP32 board version 2 to test again with S3 & DEV boards Thanks!

Jason2866 commented 2 weeks ago

2040 is working perfectly fine.

Buddy-Matt commented 2 weeks ago

@Jason2866 - #2040 isn't working on the M5Stack NanoC6 under Arduino IDE. Have commented on the relevant PR

I'm able to decode my remote using this pull request

BorisKofman commented 2 weeks ago

@Jason2866 Tested with ESP32-C6 WROOM1, ESP32 WROVER and the code is working on Esp32 Core version 3. Thanks!

BorisKofman commented 2 weeks ago

@NiKiZe @Jason2866 Thank you for feedback did the required changes Thanks!

NiKiZe commented 2 weeks ago

I would suggest this: https://github.com/crankyoldgit/IRremoteESP8266/compare/master...NiKiZe:IRremoteESP8266:ForPr2144?expand=1

Or to see my suggestions on their own: https://github.com/crankyoldgit/IRremoteESP8266/commit/4ef02e5eb6a503cbc4034812d378ab2720ee9a69

I would like to improve on the #ifdef logic further and maybe rename the old HACK one as will, but maybe not in this PR.

NiKiZe commented 1 week ago

I have updated and pushed "reverts" of lines that don't need change. (mostly indentation and comments) Modified the corev3 define to follow the pattern of others, and also tried a rename.

@crankyoldgit if you have the time I would especially like your input of how to deal with the comments on #elif and #endif for these cases.

BorisKofman commented 12 hours ago

Hi @NiKiZe @crankyoldgit @Jason2866, I in middle of vacation and can't update your request. Maybe someone please can finish it or I will try to finishing next weak. Thanks!