search

crankyoldgit / IRremoteESP8266

Infrared remote library for ESP8266/ESP32: send and receive infrared signals with multiple protocols. Based on: https://github.com/shirriff/Arduino-IRremote/
GNU Lesser General Public License v2.1
2.96k stars 832 forks source link

LEGO PF #641

Closed mike2nl closed 5 years ago

mike2nl commented 5 years ago

@markszabo Hi, No issue at all, a question only.

Ok yours is the most accurate and actual version of the IR control for the ESP. Is there any issue with the Lego PF Function, or has no user asked about it?

Thanks for any information and/or advise.

crankyoldgit commented 5 years ago

I can't remember why I didn't move it over. I'll take another look at it and see what can be done.

crankyoldgit commented 5 years ago

Looking at the code again, I can see why I didn't move it over into v2.0+. It doesn't have a decoder and the code was difficult to read, so it got put in the "I'll get around to it eventually" basket.

You're the first person to notice.

Do you have any raw data or specifications for the protocol at all? If I have those, I can write a clean(er) implementation of it.

mike2nl commented 5 years ago

@crankyoldgit Thanks for your effort. I will take a look in what i have to help out.

mike2nl commented 5 years ago

@crankyoldgit my server was faster to find the specs for it then i with searching, haha. Here it is. Look at page 6 there it starts. I hope it helps...

BTW: LEGO is a Registrated Trademark of the Lego Group. ;-)

Doc: LEGO_Power_Functions_RC_v120.pdf

crankyoldgit commented 5 years ago

After quickly skimming the protocol spec, I can now see why the author of the previous implementation didn't write a decoder for it. I'm not sure this library could easily decode it AND still auto detect all the other different protocols it supports.

For the time being, I'll look at just converting the existing code over "as is".

Do you have a capture of the real remote from IRrecvDumpV2 that you can supply?

mike2nl commented 5 years ago

@crankyoldgit Thanks for the information. No i have no capture because my ir shield for the wemos d1 mini v3.1.0 i have not received. I think it will be next weekend. Then i can do a test with it. Thanks for the advise.

crankyoldgit commented 5 years ago

@mike2nl I've added lego support in the following branch: https://github.com/markszabo/IRremoteESP8266/tree/lego

Please try it out and let me know how you go.

mike2nl commented 5 years ago

@crankyoldgit wow, yes will test it on friday evening or saturday, because the ir shield for the Wemos D1 mini arrives on friday afternoon. Cool work!

crankyoldgit commented 5 years ago

FYI, this has been included in the newly released v2.6.0 of the library.