Having an order with partial operations with different prices the sum of each should be the resulting value of this new column.
Any background context you want to provide?
I saw that HB does not sum correctly the total of each operation where there were different prices from the order price, so.
Example:
Order type: Sell
Order price: 100
Order qty: 10
Operations
Sell: 5 @ 102
Sell 5 @ 101
Expected total: 1015
Current total in HB: 1000
What are the relevant tickets?
NA
Screenshots (if appropriate)
In HB we can see that total is not correct when the
operations had a better price
We can see that the data frame has the correct value for operated values
symbol settlement operation_type size price remaining_size datetime status cancellable total
order_number
XXXX AY24 48hs SELL 696 5224.00 0 2020-01-10 11:43:47 COMPLETED False 36366.000
Questions
I would like to discuss the name of the column to follow a naming convention and maybe put it at the end to avoid breaking changes for users accessing to column index
Please, ponele la version 0.51 en el init.py dentro del directorio pyhomebroker asi queda el merge completo con el cambio de version.
El cambio parece bastante sencillo, pero por las dudas (mas que nada por cualquier posible incompatilibidad con las distintas versiones de Home Broker) voy a hacer el merge en github solamente para probar y unas vez que se pruebe lo subo al pypi.
What does this PR do?
Where should the reviewer start?
Calc of the new column here
How should this be manually tested?
Having an order with partial operations with different prices the sum of each should be the resulting value of this new column.
Any background context you want to provide?
I saw that HB does not sum correctly the total of each operation where there were different prices from the order price, so.
Example:
Order type: Sell
Order price: 100
Order qty: 10
Operations
Expected total: 1015
Current total in HB: 1000
What are the relevant tickets?
NA
Screenshots (if appropriate)
operations had a better price
We can see that the data frame has the correct value for operated values
Questions