Closed nettrino closed 1 month ago
We should probably define
169.254.169.254
as aconst
in this file and use that everywhere, but I don't mind leaving that till later.
Agreed - not sure though if there are lists of IPs that differ slightly per provider? this plugin could be split / refactored in the future so left it as such for now as I treated it as a nit as well
not sure though if there are lists of IPs that differ slightly per provider
For this particular case, I think we'd be pretty safe even if we added more cloud providers. My understanding is that 169.254.0.0/16
is reserved for link-local addressing, and it's pretty standard for the instance metadata service to be available via 169.254.169.254
. At least also for:
Alibaba Cloud uses a different address: https://www.alibabacloud.com/help/en/ecs/user-guide/view-instance-metadata (not arguing against or for, just providing an example).
Cool, thanks.
Yeah, I've got no context for Alibaba Cloud. Looks like it's different for Tencent Cloud too.
I suggest merging with the edited shorter PR title - commit title would be longer than 72 chars otherwise, which overflows e.g. GitHub's commit view.
CHANGELOG.md
if necessaryIssue
Fixes #292